Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24168] Fixed the problem that the critical section is not returned when an error occurs after entering it in function logpb_copy_page. #3333

Merged
merged 3 commits into from
Jan 25, 2022

Conversation

keonwoo98
Copy link
Contributor

@keonwoo98 keonwoo98 commented Jan 20, 2022

http://jira.cubrid.org/projects/CBRD/issues/CBRD-24168

Purpose
In the logpb_copy_page(), if the thread has entered critical section as reader and the current index in the log buffer is invalid, it should exit critical section since it's error.

Implementation
Inserted an escape condition to exit critical section on error.

Remarks
N/A

…ned when an error occurs after entering it in function logpb_copy_page
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #3333 (5961658) into develop (489c314) will increase coverage by 45.67%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3333       +/-   ##
============================================
+ Coverage     0.00%   45.67%   +45.67%     
============================================
  Files          469      500       +31     
  Lines       360689   396866    +36177     
============================================
+ Hits             0   181262   +181262     
+ Misses      360689   215604   -145085     
Impacted Files Coverage Δ
src/transaction/log_page_buffer.c 35.30% <0.00%> (+35.30%) ⬆️
src/loaddb/load_db.c 0.00% <0.00%> (ø)
src/broker/broker_recv_fd.c 0.00% <0.00%> (ø)
src/loaddb/load_error_handler.cpp 0.00% <0.00%> (ø)
src/xasl/xasl_unpack_info.hpp
src/compat/dbtype.h
src/heaplayers/utility/align.h
src/storage/external_sort.c 47.44% <0.00%> (ø)
src/executables/javasp.cpp 47.03% <0.00%> (ø)
src/storage/overflow_file.c 62.05% <0.00%> (ø)
... and 371 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489c314...5961658. Read the comment docs.

@eido5
Copy link
Contributor

eido5 commented Jan 21, 2022

Thank you for your first contribution.

…ned when an error occurs after entering it in function logpb_copy_page.
…ned when an error occurs after entering it in function logpb_copy_page.
Copy link
Contributor

@joohok joohok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hornetmj hornetmj changed the title [CBRD-24168] Fixed the problem that the critical section is not retur… [CBRD-24168] Fixed the problem that the critical section is not returned when an error occurs after entering it in function logpb_copy_page. Jan 25, 2022
@hornetmj hornetmj merged commit 38d9064 into CUBRID:develop Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants