-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CBRD-24168] Fixed the problem that the critical section is not returned when an error occurs after entering it in function logpb_copy_page. #3333
Conversation
…ned when an error occurs after entering it in function logpb_copy_page
Codecov Report
@@ Coverage Diff @@
## develop #3333 +/- ##
============================================
+ Coverage 0.00% 45.67% +45.67%
============================================
Files 469 500 +31
Lines 360689 396866 +36177
============================================
+ Hits 0 181262 +181262
+ Misses 360689 215604 -145085
Continue to review full report at Codecov.
|
Thank you for your first contribution. |
…ned when an error occurs after entering it in function logpb_copy_page.
…ned when an error occurs after entering it in function logpb_copy_page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
http://jira.cubrid.org/projects/CBRD/issues/CBRD-24168
Purpose
In the
logpb_copy_page()
, if the thread has entered critical section as reader and the current index in the log buffer is invalid, it should exit critical section since it's error.Implementation
Inserted an escape condition to exit critical section on error.
Remarks
N/A