Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBRD-20687] disk_rv_undo_format: expect temporary volumes #356

Merged
merged 2 commits into from Nov 28, 2016
Merged

[CBRD-20687] disk_rv_undo_format: expect temporary volumes #356

merged 2 commits into from Nov 28, 2016

Conversation

ribram
Copy link
Contributor

@ribram ribram commented Nov 28, 2016

http://jira.cubrid.org/browse/CBRD-20687

Creating temporary volumes also log undo of RVDK_FORMAT. If the log is rollbacked, it is not yet added to cache. If it is undone during recovery, no temporary volumes are loaded to cache. It is enough to update volid check to:

assert (disk_Cache->nvols_perm <= volid);

@ribram ribram added the bug label Nov 28, 2016
eseokoh
eseokoh approved these changes Nov 28, 2016
View reviewed changes
Copy link
Contributor

@eseokoh eseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :)

@ribram ribram merged commit 00b9be3 into CUBRID:develop Nov 28, 2016
@ribram ribram deleted the CBRD-20687 branch November 28, 2016 16:28
@eseokoh eseokoh modified the milestone: banana pie May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseokoh eseokoh eseokoh approved these changes

Assignees

@eseokoh eseokoh

Labels
bug
Projects
None yet
Milestone
banana pie
2 participants
@ribram @eseokoh