[CBRD-20210] S_LOCK on referenced table when altering a trigger. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged; lock referenced class with S_LOCK for alter, no lock for rename
|
It looks nice. Please merge the fix. |
ribram
pushed a commit
to ribram/cubrid
that referenced
this pull request
May 21, 2021
* Refactor debug code of communication_channel (debug flag is set externally). * astyle * Rename variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-20210
We used to have SCH_M_LOCK in banana, because trigger OID changed when altered. Therefore, db_class entry of table also had to be updated (where trigger OID's were kept).
We no longer change trigger OID and we do not require to update db_class entry. We still use S_LOCK to prevent conflicts with concurrent DML statements.