[CBRD-25257] Include headers of wrapping functions into "all" cubrid files #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hornetmj
reviewed
May 13, 2024
| @@ -243,6 +243,12 @@ jobs: | |||
| fi | |||
| fi | |||
|
|
|||
| filename=$(basename $f) | |||
There was a problem hiding this comment.
This check is more efficent just after file type checking like .c or .cpp.
There was a problem hiding this comment.
This behavior modifies the check results for files not present in cubrid/CMakeLists.txt, converting the check result from FAIL to PASS. If we move it as you suggested, it will create a larger condition statement structure wrapping the check section. Are you suggesting this behavior to skip the check altogether?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25257
Fix new workflow with adding false include memory_wrapper.hpp in the files not using it.