-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CBRD-25359] uhosts version of freeaddrinfo () to release memory explicitly #5202
[CBRD-25359] uhosts version of freeaddrinfo () to release memory explicitly #5202
Conversation
|
||
if (res) | ||
{ | ||
FREE_MEM (res->ai_canonname); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good to me to replace malloc to MALLOC() macro if you want to use FREE_MEM() macro. Or how about use free()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea to use MALLOC and FREE_MEM as a pair in point of memory managements.
fixed.
Since this issue occurs in a situation where memory monitoring project is applied, I believe it is appropriate to change the target branch for merging from the |
@kisoo-han To explain further, we are performing regression testing in {{memory_monitoring_ver2_merge}} branch. We requested this because we thought it would be better if the changes made in this PR were verified together. I feel like the request was made without sufficient reason, so I would like to explain further. thank you for the quick response. Also, I apologize for the sudden change request. |
This issue will be moved to #5211 due to base branch problem. |
http://jira.cubrid.org/browse/CBRD-25359
Description