[CBRD-20291] fix vacuum to correctly follow the page chain when deallocates a non-first vacuum data page. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocates a non-first vacuum data page.
ribram
added a commit
to ribram/cubrid
that referenced
this pull request
May 21, 2021
https://arniadb.atlassian.net/browse/SC-216 Fix all warnings for GCC 8 & GCC 9, and activate errors on warnings for the compilation of most libraries and executable. Set WITH_GCC_ERRORS to OFF to deactivate compilation errors (not recommended). * [SC-242] Fix -Wreturn-type warnings (CUBRID#83) https://arniadb.atlassian.net/browse/SC-242 Add default to switches missing returning values. * server_state_string: Return on default * is_process_registered: return false by default * [SC-243] catcls_get_server_compat_info: remove source length from strncpy (CUBRID#85) https://arniadb.atlassian.net/browse/SC-243 Source length does not matter for strncpy. * [SC-240] logpb_initialize_header: initializer header instead of memset (CUBRID#78) https://arniadb.atlassian.net/browse/SC-240 Fix warning by using value-initialize. Add log_header::init to do value-initialize on pre-allocated object. * [SC-244] css_return_entry_of_server: remove always-true assert (CUBRID#87) https://arniadb.atlassian.net/browse/SC-244 Remove always-true assert causing warning. * [SC-245] admin_getid_cmd: use destination buffer size for strncpy (CUBRID#88) https://arniadb.atlassian.net/browse/SC-245 NAME_MAX = 256 BROKEN_NAME_LEN = 64 Use buffer size (BROKEN_NAME_LEN) & strncpy_size for safe string copy. * [SC-241] Fix -Wsign-compare warnings (CUBRID#86) https://arniadb.atlassian.net/browse/SC-241 Compare int to int or size_t to size_t. * subtran_applier::execute: compare int&int instead of int&size_t * Fix unit tests Wsign-compare warnings * [SC-240] Fix unittests_snapshot Wclass-memaccess warnings (CUBRID#81) https://arniadb.atlassian.net/browse/SC-240 a) logtb_initialize_tdes_for_mvcc_testing: do not call memset; necessary fields are initialized. b) properly initialize thread entries. side-note: new [] does not construct each object. * [SC-240] Replace memset or_attribute with value-initialize (CUBRID#79) https://arniadb.atlassian.net/browse/SC-240 Add constructors & init functions to or_attribute & or_default_value. Use or_malloc_and_init_attribute_array instead of malloc + memset to allocate arrays of or_attribute objects. Fixes warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ... with no trivial copy-assignment; use value-initialization instead [-Wclass-memaccess] * [SC-275] Fix GCC 9.2 stringop-truncation warnings (CUBRID#95) https://arniadb.atlassian.net/browse/SC-275 Use strncpy_bufsize macro to safely copy string into a buffer. * [SC-246] Activate GCC compile errors on warnings for most libs/execs (CUBRID#93) https://arniadb.atlassian.net/browse/SC-246 Build a common list of flags and use target_compile_options to activate errors on warnings for most libraries and executables. Grammar, external projects and compat executables are excluded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slip of CBRD-20255 as #78.
(*data_page)was deallocated. It should beprev_data_pageto follow the page chain.