Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates segments version #308

Merged
merged 3 commits into from
Jan 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ Unreleased
- Added `test_split.py` to `tests/test_data`. (\#256)
- Handled Cantonese for scraping. (\#277)
- Added exclusion for reconstructions. (\#302)
- Added Vietnamese contour tone grouping test in `tests/test_config.py` (\#308)

#### Changed

Expand All @@ -131,6 +132,7 @@ Unreleased
- Moved previous contents of `tests` into `tests/test_wikipron` (\#226)
- Updated the packages version numbers in requirements.txt to their latest according to PyPI (\#239)
- Updated the default pron selector to also look for IPA strings under paragraphs in addition to list items. (\#295)
- Updated segments package version to 2.2.0 (\#308)

#### Deprecated

Expand Down
4 changes: 1 addition & 3 deletions data/phones/vie_hanoi_phonetic.phones
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,5 @@ i͡ə
ɨ͡ə
u͡e
# GLOTTALIZED TONES
# Due to an issue with Python's `segments` library, the glottalization
# diacritic was dropped from the following tones:
˧ˀ˨ # Often transcribed /˧˨ʔ/ on Wiktionary.
˦ˀ˥
˦ˀ˥
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ mypy==0.790
pytest==6.1.1
requests-html==0.10.0
requests==2.24.0
segments==2.1.3
segments==2.2.0
setuptools==50.3.1
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def main():
"iso639",
"requests",
"requests-html",
"segments>=2.1.3,<3",
"segments>=2.2.0,<3",
"setuptools",
],
entry_points={"console_scripts": ["wikipron = wikipron.cli:main"]},
Expand Down
1 change: 1 addition & 0 deletions tests/test_wikipron/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ def test_process_pron(stress, syllable_boundaries, input_pron, expected_pron):
(True, "ʷoˈtɤu̯", "ʷo ˈt ɤ u̯"),
(True, "ⁿdaˈɽá.ma", "ⁿd a ˈɽ á . m a"),
(False, "lɛ̃.ɡɥis.tik", "lɛ̃.ɡɥis.tik"),
(True, "ʔɓaːn˧˩ ŋaː˦ˀ˥", "ʔ ɓ aː n ˧˩ # ŋ aː ˦ˀ˥"),
],
)
def test_segment(segment, input_pron, expected_pron):
Expand Down