Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow lazy import of arviz #327

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Allow lazy import of arviz #327

merged 1 commit into from
Dec 7, 2023

Conversation

nabriis
Copy link
Collaborator

@nabriis nabriis commented Dec 7, 2023 •
edited

Allows lazy import of arviz. This means user with install issues can run pip install cuqipy --no-deps and likely get most of the functionality to work

amal-ghamdi
amal-ghamdi approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great timing :)

@nabriis nabriis requested a review from chaozg December 7, 2023 10:01
chaozg
chaozg approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@chaozg chaozg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabriis nabriis merged commit 2a8abe2 into main Dec 7, 2023
6 checks passed
@nabriis nabriis deleted the allow_lazy_import_of_arviz branch December 7, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amal-ghamdi amal-ghamdi amal-ghamdi approved these changes

@chaozg chaozg chaozg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nabriis @amal-ghamdi @chaozg