Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Blacklisting doesn't remove song from playlist. #114

Open
BumbleFlash opened this issue Dec 11, 2020 · 1 comment
Open

Blacklisting doesn't remove song from playlist. #114

BumbleFlash opened this issue Dec 11, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@BumbleFlash
Copy link

Describe the bug
Blacklisting the song removes the song from the library but doesn't remove the song from the playlist.

To Reproduce
Steps to reproduce the behavior:

  1. Click on the Overflow Button (Triple vertical dot) song/album
  2. Click on Blacklist
  3. Go to the playlist to which the song was added
  4. The song still exists.

Expected behavior
The song should be hidden from the playlist.

Observed behavior
The song still shows up on the playlist

Device and Android version:

Google Pixel 3a, Android 11, Stock, Google Play Services 20.45.16

@BumbleFlash BumbleFlash added the bug Something isn't working label Dec 11, 2020
@barbeau
Copy link
Member

barbeau commented Dec 11, 2020

We should rename from "Blacklist" to "Disable".

I would expect that the song remain on the playlist, but just be faded to indicate that it's disabled as proposed in #115 and the song would be skipped when the player gets to that point in the playlist. That way if a user "enables" the song later, their playlists are still intact. If they want to remove it from a playlist, they can choose the "remove from playlist" option (which still remains to be implemented).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants