Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Fadeout container for blacklisted song/album/artist. #115

Open
BumbleFlash opened this issue Dec 11, 2020 · 3 comments
Open

Fadeout container for blacklisted song/album/artist. #115

BumbleFlash opened this issue Dec 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@BumbleFlash
Copy link

Is your feature request related to a problem? Please describe.
Blacklisting could be potentially improved by fading out the song from the library instead of removing it altogether. That way, we could do the same if not similar behaviour for a blacklisted song already present in the playlist.

Describe the solution you'd like
Fade out the information container if the song is blacklisted.

Describe alternatives you've considered
Leave it as-is.

@BumbleFlash BumbleFlash added the enhancement New feature or request label Dec 11, 2020
@barbeau
Copy link
Member

barbeau commented Dec 11, 2020

We should also rename the "Blacklist" feature to "Disable"

@BumbleFlash
Copy link
Author

Per discussion today, we think changing the behavior of Blacklisting could be trickier than we thought.

To track we discussed,

  1. Remove the code from the InclExclTransformer() function that filters the blacklisted song entirely. Add a public function in the SongRepository that returns the list of blacklisted items. Have an overlay view on the data containers that can be set to visible for a blacklisted song to fade out the container.

  2. Have a property isBlacklisted in the Song model class and set it true when the path of the song appears in the blacklisted items.

@barbeau
Copy link
Member

barbeau commented Jan 4, 2021

Per previous discussions, we're going to table this for now and just remove the "Blacklist" feature from the UI and revisit in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants