Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature today animation #269

Closed
wants to merge 2 commits into from
Closed

Feature today animation #269

wants to merge 2 commits into from

Conversation

dbmrq
Copy link
Contributor

@dbmrq dbmrq commented Mar 30, 2016

This improves the Today button animation with the code described at
#185.

This improves the Today button animation with the code described at
#185.
@dbmrq
Copy link
Contributor Author

dbmrq commented Apr 3, 2016

Now I had the time to test this a little further and the animation looks almost perfect when there aren't any dot markers. When using dot markers it can look a little weird, though.

The animation scrolls to the following or to the previous month, depending on whether you're at a month before or after today, and then it fades in the current month. When there aren't any dot markers you can't notice this happens, but otherwise it could be a problem.
Assume, for instance, you have dot markers for all previous months, and none for the current month. Then scroll to one year from now and tap "Today". It'll scroll to one month before today and show a lot of dot markers, and then it'll fade in the current month, that doesn't have any. So it'll look like it flashed some dot markers randomly. Dot markers are already pretty unreliable, though, since they can't be updated (#267), so, if not using them, this is fine. I tried fixing this problem, but I don't see an obvious solution, we'd have to think it over.

For now I went back to the previous animation, I just think it looks better if it's done a little faster, so I changed the duration from 0.8 to 0.25. It looks quite alright.

@stale
Copy link

stale bot commented Mar 8, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Thank you for your contributions.

@stale stale bot added the Stale label Mar 8, 2018
@stale
Copy link

stale bot commented Mar 15, 2018

This issue has been automatically closed because it has been inactive for 45 days.

@stale stale bot closed this Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant