modifications for self protection in CVCalendarMonthContentVC, and CV… #466
Conversation
…Date comma removal
|
@dhsu210 Thanks for the PR. Can you please explain to me what you're trying to achieve or what this PR aims to fix? |
|
I noticed that you used a guard let for strongSelf in nextMonth (but not previousMonth), which was causing the calendar to crash if users selected a date in the previous month by clicking on some of the greyed out dates (i.e. if they are in August 2017, but select July 31st). This was meant to be an internal PR, but I figured it might help everyone else who is experiencing the crashes. You can ignore the comma change in CVDate though, that was just a UI preference for my own implementation. Feel free to close this PR (I couldn't quite figure out how to close it from my end) and only implement the changes that you feel are necessary. |
|
I'm adapting your PR as it is as I think it's a good fix, thank you! Feel free to add further PRs 👍 |
…Date comma removal