Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing a CVE record should throw a 400 if datePublic is a future date #1097

Closed
jdaigneau5 opened this issue Jul 12, 2023 · 0 comments
Closed

Publishing a CVE record should throw a 400 if datePublic is a future date #1097

jdaigneau5 opened this issue Jul 12, 2023 · 0 comments
Assignees
@jdaigneau5
Projects
Sprint 34 (8/7 - 8/18)

Comments

@jdaigneau5
Copy link
Collaborator

Summary

Currently, the datePublic field in a CVE record can be set to anytime, including future dates. This is misleading because the record will be published immediately after the request is made, regardless of the datePublic field. Validation should be updated to catch instances of datePublic values and throw an error explaining why.

Definition of Done

  • Future datePublic fields are no longer allowed when publishing CVE records
  • A helpful error is thrown explaining the above case (i.e. datePublic times cannot occur in the future)
@github-actions github-actions bot added this to Needs Triage in Issue Triage Jul 12, 2023
@jdaigneau5 jdaigneau5 moved this from Needs Triage to Needs Discussion in Issue Triage Jul 12, 2023
@jdaigneau5 jdaigneau5 changed the title DRAFT: Publishing a CVE record should throw a 400 if datePublic is a future date Publishing a CVE record should throw a 400 if datePublic is a future date Jul 18, 2023
@jdaigneau5 jdaigneau5 moved this from Needs Discussion to High Priority in Issue Triage Jul 27, 2023
@jdaigneau5 jdaigneau5 removed this from High Priority in Issue Triage Aug 10, 2023
@jdaigneau5 jdaigneau5 moved this from To do to In progress in Sprint 34 (8/7 - 8/18) Aug 10, 2023
@jdaigneau5 jdaigneau5 self-assigned this Aug 10, 2023
jdaigneau5 added a commit that referenced this issue Aug 11, 2023
@jdaigneau5
#1097 created middleware to check for future datePublics
ec554b7
jdaigneau5 added a commit that referenced this issue Aug 11, 2023
@jdaigneau5
#1097 added tests for datePublic validator
87e2da5
@jdaigneau5 jdaigneau5 mentioned this issue Aug 11, 2023
Merged
2 tasks
jdaigneau5 added a commit that referenced this issue Aug 11, 2023
@jdaigneau5
#1097 fixed tests
68da425
@jdaigneau5 jdaigneau5 moved this from In progress to In Review in Sprint 34 (8/7 - 8/18) Aug 11, 2023
@jdaigneau5 jdaigneau5 moved this from In Review to Done in Sprint 34 (8/7 - 8/18) Aug 21, 2023
@ElectricNroff ElectricNroff mentioned this issue Dec 8, 2023
Closed
@ElectricNroff ElectricNroff mentioned this issue Jan 7, 2024
Closed
@mprpic mprpic mentioned this issue Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdaigneau5 jdaigneau5

Labels
None yet
Projects
No open projects
Sprint 34 (8/7 - 8/18)
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdaigneau5