Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUT /org/:shortname/user/:username with empty payload responds that the user had been updated #745

Closed
brettp opened this issue Jun 29, 2022 · 0 comments · Fixed by #909
Closed

PUT /org/:shortname/user/:username with empty payload responds that the user had been updated #745

brettp opened this issue Jun 29, 2022 · 0 comments · Fixed by #909
Assignees
@slubar
Projects
Sprint 17 October 17 - October 28

Comments

@brettp
Copy link
Collaborator

brettp commented Jun 29, 2022

An empty JSON payload shouldn't result in a status message that says changes were saved. HTTP 200 (or 204) should continue to be returned since it was a valid request, but the response body should indicate nothing was changed.
@brettp brettp created this issue from a note in Soft Deploy (Needs Triage) Jun 29, 2022
@github-actions github-actions bot added this to Needs Triage in Issue Triage Jun 29, 2022
@slubar slubar moved this from Needs Triage to Low Priority in Issue Triage Jun 30, 2022
@slubar slubar removed this from Needs Triage in Soft Deploy Jul 6, 2022
@jdaigneau5 jdaigneau5 removed this from Low Priority in Issue Triage Sep 19, 2022
@slubar slubar self-assigned this Oct 19, 2022
@slubar slubar moved this from To Do to In Progress in Sprint 17 October 17 - October 28 Oct 19, 2022
slubar added a commit that referenced this issue Oct 26, 2022
@slubar
#745 improve messaging for user update with no changes specified
8eb5c8f
@slubar slubar linked a pull request Oct 26, 2022 that will close this issue
#745 improve messaging for user update with no changes specified #909
Merged
@slubar slubar moved this from In Progress to In Review in Sprint 17 October 17 - October 28 Oct 26, 2022
brettp added a commit that referenced this issue Oct 26, 2022
@brettp
Merge pull request #909 from CVEProject/srl-745
325d21b 
#745 improve messaging for user update with no changes specified
Sprint 17 October 17 - October 28 automation moved this from In Review to Done Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slubar slubar

Labels
None yet
Projects
No open projects
Sprint 17 October 17 - October 28
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#745 improve messaging for user update with no changes specified CVEProject/cve-services
2 participants
@brettp @slubar