Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad Error Messages for POST /cve/:id/cna and POST /org/:shortname/user Endpoints #749

Closed
2 tasks
jdaigneau5 opened this issue Jul 1, 2022 · 0 comments · Fixed by #1005
Closed
2 tasks

Bad Error Messages for POST /cve/:id/cna and POST /org/:shortname/user Endpoints #749

jdaigneau5 opened this issue Jul 1, 2022 · 0 comments · Fixed by #1005
Assignees
@jdaigneau5
Projects
Sprint 24 January 23 - February 3

Comments

@jdaigneau5
Copy link
Collaborator

These endpoints have error messages that should be improved:

  • POST /cve/:id/cna when the CNA does not own the id throws the error "It appears the user does not own the CVE".

  • POST /org/:shortname/user when an admin CNA user is attempting to create a user for a different org throws the error "This information can only be viewed or modified by the Secretariat or Org Admin". This is misleading because the user is an Admin but trying to create a user in a different org, not view or modify something.

Definition of Done

  • Improved error message for POST /cve/:id/cna
  • Improved error message for POST /org/:shortname/user
@github-actions github-actions bot added this to Needs Triage in Issue Triage Jul 1, 2022
@jdaigneau5 jdaigneau5 moved this from Needs Triage to Low Priority in Issue Triage Jul 11, 2022
@jdaigneau5 jdaigneau5 removed this from Low Priority in Issue Triage Jan 30, 2023
@jdaigneau5 jdaigneau5 self-assigned this Feb 1, 2023
@jdaigneau5 jdaigneau5 moved this from To Do to In Progress in Sprint 24 January 23 - February 3 Feb 1, 2023
jdaigneau5 added a commit that referenced this issue Feb 2, 2023
@jdaigneau5
#749 Updated error messages
87ca944
@jdaigneau5 jdaigneau5 mentioned this issue Feb 2, 2023
Merged
3 tasks
@jdaigneau5 jdaigneau5 linked a pull request Feb 2, 2023 that will close this issue
Resolves #749 Updated error messages for creating and updating users and creating CVE records #1005
Merged
3 tasks
jdaigneau5 added a commit that referenced this issue Feb 2, 2023
@jdaigneau5
#749 Fixed tests
a87a272
jdaigneau5 added a commit that referenced this issue Feb 2, 2023
@jdaigneau5
#749 more test fixes
c007365
@jdaigneau5 jdaigneau5 moved this from In Progress to In Review in Sprint 24 January 23 - February 3 Feb 2, 2023
jdaigneau5 added a commit that referenced this issue Feb 2, 2023
@jdaigneau5
#749 updated updateUser error message
27f34f3
brettp added a commit that referenced this issue Feb 3, 2023
@brettp
Merge pull request #1005 from CVEProject/jd-749
1c23e82 
Resolves #749 Updated error messages for creating and updating users and creating CVE records
Sprint 24 January 23 - February 3 automation moved this from In Review to Done Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdaigneau5 jdaigneau5

Labels
None yet
Projects
No open projects
Sprint 24 January 23 - February 3
Done
Milestone
No milestone
1 participant
@jdaigneau5