Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error message and behavior when creating org with UUID #887

Closed
slubar opened this issue Sep 28, 2022 · 0 comments · Fixed by #1007
Closed

Incorrect error message and behavior when creating org with UUID #887

slubar opened this issue Sep 28, 2022 · 0 comments · Fixed by #1007
Assignees
@brettp
Projects
Sprint 24 January 23 - February 3
Milestone
CVE Services 2.1

Comments

@slubar
Copy link
Contributor

slubar commented Sep 28, 2022 •
edited

UUID is not allowed as part of the JSON body for POST /api/org in v2.1. There are two problems with what happens currently when it is included:

  1. The error message currently reads, "Providing UUIDs for user creation or update is not allowed."
  2. The org is created anyway

Two fixes should be made:

  1. Replace the error message with "Providing UUIDs for org creation is not allowed"
  2. Do not create the org when this error occurs
@slubar slubar added this to the CVE Services 2.1 milestone Sep 28, 2022
@github-actions github-actions bot added this to Needs Triage in Issue Triage Sep 28, 2022
@slubar slubar moved this from Needs Triage to Low Priority in Issue Triage Sep 28, 2022
@slubar slubar moved this from Low Priority to Needs Triage in Issue Triage Sep 28, 2022
@slubar slubar changed the title Incorrect error message when creating org with UUID Incorrect error message and behavior when creating org with UUID Sep 28, 2022
@slubar slubar moved this from Needs Triage to Low Priority in Issue Triage Sep 28, 2022
@jdaigneau5 jdaigneau5 removed this from Low Priority in Issue Triage Jan 23, 2023
@brettp brettp moved this from To Do to In Progress in Sprint 24 January 23 - February 3 Feb 1, 2023
@brettp brettp self-assigned this Feb 1, 2023
@brettp brettp moved this from In Progress to To Do in Sprint 24 January 23 - February 3 Feb 1, 2023
@brettp brettp moved this from To Do to In Progress in Sprint 24 January 23 - February 3 Feb 3, 2023
brettp added a commit that referenced this issue Feb 3, 2023
@brettp
Fixes #887. Do not create orgs if UUID is passed. Correct error messa…
a50cd07 
…ges.
brettp added a commit that referenced this issue Feb 3, 2023
@brettp
Fixes #887. Do not create orgs if UUID is passed. Correct error messa…
58d210d 
…ges.
@brettp brettp mentioned this issue Feb 3, 2023
Merged
3 tasks
@brettp brettp moved this from In Progress to In Review in Sprint 24 January 23 - February 3 Feb 3, 2023
@jdaigneau5 jdaigneau5 linked a pull request Feb 3, 2023 that will close this issue
Resolves issue #887. Do not create orgs if UUID is passed. Correct error messages. #1007
Merged
3 tasks
jdaigneau5 added a commit that referenced this issue Feb 3, 2023
@jdaigneau5
Merge pull request #1007 from CVEProject/bep-887-uuid-err-msg
d24c2ba 
Resolves issue #887. Do not create orgs if UUID is passed. Correct error messages.
Sprint 24 January 23 - February 3 automation moved this from In Review to Done Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettp brettp

Labels
None yet
Projects
No open projects
Sprint 24 January 23 - February 3
Done
Milestone
CVE Services 2.1
2 participants
@brettp @slubar