Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #980 Fixed validation calls for rejecting new and existing CVEs #983

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Resolves #980 Fixed validation calls for rejecting new and existing CVEs #983

merged 2 commits into from
Jan 12, 2023

Conversation

jdaigneau5
Copy link
Collaborator

Closes Issue #980

Summary

RejectCVE() and rejectExistingCve() were calling validateCveRecord() incorrectly. Updated this function call to correctly validate rejected CVE objects.

Important Changes

cve.controller.js

  • updated rejectCVE() and rejectedExistingCve() to be called on the correct object.
  • Added better error logging for failed validation

@jdaigneau5 jdaigneau5 requested a review from brettp January 6, 2023 15:26
brettp
brettp previously approved these changes Jan 6, 2023
View reviewed changes
@jdaigneau5 jdaigneau5 requested a review from brettp January 9, 2023 13:51
@slubar slubar linked an issue Jan 11, 2023 that may be closed by this pull request
invalid REJECTED records accepted in production and test (no englishLanguageDescription) #980
Closed
@brettp brettp merged commit 12657d9 into dev Jan 12, 2023
@brettp brettp deleted the jd-980 branch January 12, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettp brettp brettp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid REJECTED records accepted in production and test (no englishLanguageDescription)
2 participants
@jdaigneau5 @brettp