Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes issue #591, Clarified wording of error when trying to update user to the same organization #992

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

brettp
Copy link
Collaborator

@brettp brettp commented Jan 20, 2023

Closes Issue #591

Summary

Added additional error USER_ALREADY_IN_ORG that is sent if a PUT request tries to update a user to the org it is already in.

Important Changes

  • Added new error to PUT /org/:shortname/user/:username endpoint
  • Added tests for update user first name and update user org

Testing

Steps to manually test updated functionality, if possible

  • 1) As secretariat, update an existing user and set org_short_name to their current org
  • 2) Confirm that a 403 error is returned
  • 3) Confirm the JSON error is USER_ALREADY_IN_ORG
  • 4) Confirm the JSON error message is similar to The user could not be updated because the user '${username}' already belongs to the '${shortname}' organization.

@jdaigneau5 jdaigneau5 merged commit b53a3bf into dev Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oddity for superfluous org_shortname to /org/{shortname}/user/{username} PUT
2 participants