Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2.4.0 #7

Merged
merged 12 commits into from
Jun 7, 2024
Merged

Update to 2.4.0 #7

merged 12 commits into from
Jun 7, 2024

Conversation

gregdenay
Copy link
Member

A range of modifications for better code, easier maintenance and some convienience utilities:

New features

  • Added a Taxonomy.copy() method as a shorthand for copy.deepcopy(Taxonomy)
  • Added an inplace argument to Taxonomy methods filterRanks() and prune(), allowing chose whether to return a modified deepcopy of the instance od modifiy it in place

Improvements

  • Unit tests now use temporary directories to test IO methods
  • The Taxonomy.filter() method will now return a ValueError when attempting to use root rank in the filtering instead of creating new root Nodes

Pending deprecation

  • Taxonomy.from_json will be removed in 3.0.0, it is replaced by read_json, a module level constructor.
  • load will be removed in 3.0.0, it is replaced by read_json, a module level constructor.
  • Taxonomy.from_taxdump will be removed in 3.0.0, it is replaced by read_taxdump, a module level constructor.
  • load_ncbi will be removed in 3.0.0, it is replaced by read_ncbi, a better-named module level constructor.

Bug Fix

  • Taxonomy.listDescendant now does filter output based on the ranks parameter
  • Repaired Node.node_info output to actually use newlines instead of printing '\n'

@gregdenay gregdenay merged commit 9a1fe52 into CVUA-RRW:main Jun 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant