Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

Add more position options #5

Closed
CWSpear opened this issue Jul 18, 2016 · 12 comments
Closed

Add more position options #5

CWSpear opened this issue Jul 18, 2016 · 12 comments
Labels

Comments

@CWSpear
Copy link
Owner

CWSpear commented Jul 18, 2016

I want to support full, topleft, topright, bottomleft, bottomright and possibly custom dimensions on top of that. i.e. you specify top, but you want it 600 x 400px, so it puts it at that size in the center top.

@Qard
Copy link

Qard commented Jul 19, 2016

I want full too. 😸

@CWSpear
Copy link
Owner Author

CWSpear commented Jul 20, 2016

@Qard full is unofficially supported... give it a try!

@robinweser
Copy link

Would it also be possible to just keep the window size/position as it was used before? I actually do not want to have a docked window :P

@CWSpear
Copy link
Owner Author

CWSpear commented Apr 20, 2017

@rofrischmann just don't set a position :-)

@CWSpear
Copy link
Owner Author

CWSpear commented Apr 21, 2017

In version 1.0, I'm deprecating the position option in favor of anchor. anchor makes no assumptions about the size you want (will remember size unless you set a width or height). It only cares about where the window will appear (it will be anchored where you specify). You can set the anchor to none and it won't move the window on activation.

This is not released at the time of this writing. I believe this solution will allow just about everyone to get what they wanted, but wanted help to do a little testing before I go live. Please test out hyperterm-visor@next and see if it works as expected or if you can shake out any bugs!

@RTSchriner
Copy link

@CWSpear: Sure thing! Installing now...

@CWSpear
Copy link
Owner Author

CWSpear commented Apr 21, 2017

Note, if you are putting this directly in your ~/.hyper.js config, use hyperterm-visor#next, apparently.

@RTSchriner
Copy link

@CWSpear I just tested about half of the anchor positions, so far so good. Anything I should be looking for in particular?

**Note: ** You need to restart Hyper for the changes to take affect.

@CWSpear
Copy link
Owner Author

CWSpear commented Apr 21, 2017

I think you can get away with a Full Reload (on Mac, Cmd-Shift-R) for changes to take effect.

Mostly that it does what you think it would; that it behaves in a logical way. And that different combinations work as expected.

@RTSchriner
Copy link

RTSchriner commented Apr 21, 2017

@CWSpear It does exactly what I expect it to do! Great work... love the plugin! 👍 If it wasn't for your plugin I'd still be using iTerm2.

@philwade
Copy link

Sort of a weird thing I found testing this. If I define no width in my config (but a height) on initial start the visor is 100% width. If I close the window and hit the hotkey, a new visor appears, correct height but odd width. Since this is outside the normal workflow (and I think the new window thing may have been introduced by the hotkey changes) it probably isn't super important to fix, but I thought you might want to know.

@CWSpear
Copy link
Owner Author

CWSpear commented Apr 19, 2018

This repository is no longer maintained. Feel free to fork. Probably doesn't work with the latest version of Hyper 1, and certainly unlikely to work with Hyper 2.

@CWSpear CWSpear closed this as completed Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants