-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only load downloader if needed #13
Comments
So we have an enablement config with map of PV services to downloader names, but how to validate this map Q: can we put custom |
About solution for loading only enabled downloaders:
|
FInal answer: use
|
when we have more and more downloaders choice in the futures, we can't force users to fill in all downloaders config, so we need:
will probably use springBIG NOTICE: base on Spring Doc, Spring Boot issue 1 and issue 2, any@ConditionOnBean
to check if the corresponding downloader config exist@ConditionalOn
annotations that rely on knowledge about Spring beans will NOT work outside of Spring auto-configuration (PS:@ConditionalOnProperty
would probably work)downloader config bean isBecause of this, SpEL can not resolve properties (except@ConditionOnExpression
with the check if its name is in enablement config map@Value
). So we need another solution to load only enabled downloadersThe text was updated successfully, but these errors were encountered: