Allow @ConditionalOn to work on @Components

[xenoterracide]

@Service
@ConditionalOnMissingBean(PatientService::class)
class DetachedPatientService(private val emrRepo: EmrRepository) : PatientService {

I get this result

Parameter 2 of constructor in com.potreromed.gateway.usecase.InitialFoleySetupApplicationService required a bean of type 'com.potreromed.gateway.model.PatientService' that could not be found.
    Action:
    Consider defining a bean of type 'com.potreromed.gateway.model.PatientService' in your configuration.

this does work... but it's so much more verbose

@Configuration
open class DetachedConfig {

    @Bean
    @ConditionalOnMissingBean
    open fun detachedPatientService(repo: EmrRepository): PatientService {
        return DetachedPatientService(repo)
    }
}

it would be nice if we could use @ConditionalOnMissingBean and other @Conditional's on @Component's.

P.S. I can create a full demo project if necessary.

[philwebb]

@xenoterracide How are your service beans being imported? I believe that Spring Framwork's @Condition support should work on components, however, Spring Boot conditions (and @ConditionalOn...Bean especially) are very sensitive to when they run. You can really only use them on auto-configuration classes. There's a small warning about this in the javadoc.

[xenoterracide]

imported? I presume you're asking how I'm injecting them... (otherwise just the normal import) I'm using constructor injection into other services.

@Service
open class InitialFoleySetupApplicationService(
    private val foleyRepo: FoleyRepository,
    private val emrRepo: EmrRepository,
    private val patientSvc: PatientService,
    private val mfcRepo: MonitorFoleyConnectionRepository,
    private val monitorRepo: MonitorRepository,
    private val site: SiteConfig
) {

[snicoll]

@xenoterracide using conditions on components identified by classpath scanning will not work. You should really use those on auto-configurations (see the note in the javadoc that Phil already linked).

Ignoring the fact using such conditions that way is not supported, I don't know why your project fails the way you've described but it looks like a different problem to me. If you share a small sample we can have a look.

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[spring-projects-issues]

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.