[WIP] Metadata service #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinovlas
requested changes
May 11, 2020
django_fido/management/commands/download_authenticator_metadata.py
Outdated
Show resolved
Hide resolved
django_fido/management/commands/download_authenticator_metadata.py
Outdated
Show resolved
Hide resolved
ziima
requested changes
May 12, 2020
django_fido/management/commands/download_authenticator_metadata.py
Outdated
Show resolved
Hide resolved
django_fido/management/commands/download_authenticator_metadata.py
Outdated
Show resolved
Hide resolved
django_fido/management/commands/download_authenticator_metadata.py
Outdated
Show resolved
Hide resolved
tpazderka
force-pushed
the
metadata_service
branch
from
cc81695
to
b40a531
Compare
ziima
reviewed
May 13, 2020
ziima
requested changes
May 13, 2020
django_fido/management/commands/download_authenticator_metadata.py
Outdated
Show resolved
Hide resolved
|
Reorganized and updated according to comments. Two things belonging to this PR are still missing:
There is also a missing implementation for UAF devices, but I do not have one to test the correct behavior and attestation format... :( |
tpazderka
force-pushed
the
metadata_service
branch
2 times, most recently
from
5535ad0
to
96c5bc5
Compare
ziima
requested changes
May 19, 2020
django_fido/management/commands/download_authenticator_metadata.py
Outdated
Show resolved
Hide resolved
|
Updated |
ziima
requested changes
May 19, 2020
|
API extended. |
ziima
reviewed
May 19, 2020
ziima
requested changes
May 20, 2020
tpazderka
force-pushed
the
metadata_service
branch
from
f1574bb
to
7e57224
Compare
|
Done |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 97.77% 98.17% +0.40%
==========================================
Files 34 38 +4
Lines 1079 1426 +347
Branches 47 64 +17
==========================================
+ Hits 1055 1400 +345
- Misses 20 21 +1
- Partials 4 5 +1
Continue to review full report at Codecov.
|
stinovlas
approved these changes
May 21, 2020
ziima
requested changes
May 21, 2020
ziima
approved these changes
May 21, 2020
tpazderka
force-pushed
the
metadata_service
branch
from
c4b00fd
to
1ad7c91
Compare
tpazderka
force-pushed
the
metadata_service
branch
from
1ad7c91
to
dd6758b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.