Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Provider classes #628

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Refactor Provider classes #628

merged 1 commit into from
Mar 19, 2019

Conversation

tpazderka
Copy link
Collaborator

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.

Touch of refactoring, Updated Provider classes.

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #628 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   61.51%   61.63%   +0.11%     
==========================================
  Files          62       62              
  Lines       11140    11121      -19     
  Branches     1973     1967       -6     
==========================================
+ Hits         6853     6854       +1     
+ Misses       3727     3709      -18     
+ Partials      560      558       -2
Impacted Files Coverage Δ
src/oic/oic/provider.py 65.85% <ø> (+0.75%) ⬆️
src/oic/oauth2/provider.py 70.26% <100%> (ø) ⬆️
src/oic/utils/http_util.py 68.67% <0%> (+0.57%) ⬆️
src/oic/utils/authn/user.py 64.22% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3dfcb...797fbce. Read the comment docs.

@tpazderka
Copy link
Collaborator Author

Part of #629

Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpazderka tpazderka merged commit d099a83 into master Mar 19, 2019
@tpazderka tpazderka deleted the refactor_provider branch March 19, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants