QA: Add more checks to is_resource_writable()

Cacti · Apr 8, 2023 · 2ce9a9c · 2ce9a9c
1 parent 78dd0aa
commit 2ce9a9c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/functions.php b/lib/functions.php
@@ -7554,7 +7554,9 @@ function is_resource_writable(string $path) {
 	}
 
 	if (file_exists($path)) {
-		if (is_writable($path) && ($f = @fopen($path, 'a'))) {
+		if (is_writable($path)) {
+			return true;
+		} elseif ($f = @fopen($path, 'a')) {
 			fclose($f);
 
 			return true;
@@ -7563,7 +7565,9 @@ function is_resource_writable(string $path) {
 		return false;
 	}
 
-	if (is_writable($path) && ($f = @fopen($path, 'w'))) {
+	if (is_writable($path)) {
+		return true;
+	} elseif ($f = @fopen($path, 'w')) {
 		fclose($f);
 		unlink($path);