Fixing #5581 - Colors table upgrade failure causing upgrade failure

Due to previously never completed upgrade, future upgrades fail due to missing color table keys

CHANGELOG

@@ -120,6 +120,8 @@ Cacti CHANGELOG
 -issue#5561: Settings table custom size reverted by database repair
 -issue#5572: RRD Checker timeouts to low
 -issue#5573: Incorrect URL for editing graph template
+-issue#5581: Due to previously never completed upgrade, future upgrades fail due to missing color table keys
+-feature#5577: Provide new templates for ArubaOS switch, Aruba wifi controller and HPE iLO to be available during install
 
 1.2.25
 -security#GHSA-77rf-774j-6h3p: Protect against Insecure deserialization of filter data

install/upgrades/1_2_26.php

@@ -25,5 +25,51 @@
 function upgrade_to_1_2_26() {
 	db_install_execute("ALTER TABLE `settings` MODIFY `value` varchar(4096) not null default ''");
 	db_install_execute("ALTER TABLE `settings_user` MODIFY `value` varchar(4096) not null default ''");
+
+	/* rerun this function just in case for some reason it was missed */
+	$duplicates = db_install_fetch_assoc('SELECT hex, COUNT(*) AS totals
+		FROM colors
+		GROUP BY hex
+		HAVING totals > 1');
+
+	if (cacti_sizeof($duplicates['data'])) {
+		$duplicates = $duplicates['data'];
+
+		foreach($duplicates as $duplicate) {
+			$hexes_results = db_install_fetch_assoc('SELECT id, hex
+				FROM colors
+				WHERE hex = ?
+				ORDER BY id ASC',
+				array($duplicate['hex']), true);
+			$hexes = $hexes_results['data'];
+
+			$first = true;
+
+			foreach($hexes as $hex) {
+				if ($first) {
+					$keephex = $hex['id'];
+					$first   = false;
+				} else {
+					db_install_execute('UPDATE graph_templates_item
+						SET color_id = ?
+						WHERE color_id = ?',
+						array($keephex, $hex['id']));
+
+					if (db_table_exists('color_template_items')) {
+						db_install_execute('UPDATE color_template_items
+							SET color_id = ?
+							WHERE color_id = ?',
+							array($keephex, $hex['id']));
+					}
+
+					db_install_execute('DELETE FROM colors WHERE id = ?', array($hex['id']));
+				}
+			}
+		}
+
+		if (!db_index_exists('colors', 'hex')) {
+			db_install_add_key('colors', 'UNIQUE INDEX', 'hex', array('hex'));
+		}
+	}
 }