Fixing #5490 - Infinite Database Recursion Error

Database failure causes infinite recursion in cacti_log() followed by machine lockup
Cacti · Sep 30, 2023 · 3682057 · 3682057
1 parent 83b063d
commit 3682057
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -5,6 +5,7 @@ Cacti CHANGELOG
 -issue#5483: cacti 1.2.25 ubuntu server 22.04.3 php8.1 add device error
 -issue#5485: Selecting a host device in System Utilities - View Data Query Cache raises error in cacti log
 -issue#5489: remove_graphs.php does not handle "--preserve" option
+-issue#5490: Database failure causes infinite recursion in cacti_log() followed by machine lockup
 -issue#5492: Cacti 1.2.25 ss_host_cpu.php CPU graphs not updating anymore on Windows servers
 -issue#5493: Multi select drop down list box not rendered correctly in Chrome and Edge
 -issue#5494: typo error in name used in inserts array for selective_plugin_debug

diff --git a/lib/functions.php b/lib/functions.php
@@ -727,7 +727,7 @@ function read_config_option($config_name, $force = false) {
 		    isset($database_sessions["$database_hostname:$database_port:$database_default"])) {
 
 			// Get the database setting
-			$db_result = db_fetch_row_prepared('SELECT value FROM settings WHERE name = ?', array($config_name));
+			$db_result = db_fetch_row_prepared('SELECT value FROM settings WHERE name = ?', array($config_name), false);
 
 			if (cacti_sizeof($db_result)) {
 				$value = $db_result['value'];