Fixing Issue #4564 - Navigation second click

Cacti Top Tabs do not work when clicked for a second time
Cacti · Feb 22, 2022 · 5996b94 · 5996b94
1 parent dfc1bf8
commit 5996b94
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -54,6 +54,7 @@ Cacti CHANGELOG
 -issue#4554: PHP 8.1 Causing Automation Deprecation Errors
 -issue#4557: Undefined index in graph debug mode.
 -issue#4563: Cacti breadcrumbs are unreliable due to faulty navigation cache logic
+-issue#4564: Cacti Top Tabs do not work when clicked for a second time
 -feature: Expose hidden Language Translation setting l10n_language_handler
 -feature: Allow a Device to be a part of a Report outside of a Tree
 -feature: Allow Basic Authentication to display customer login failed message

diff --git a/include/layout.js b/include/layout.js
@@ -1190,7 +1190,13 @@ function setupResponsiveMenuAndTabs() {
 			event.preventDefault();
 		}
 
-		if ($(this).hasClass('selected') || (pageName == page && pageName != 'graph_view.php' && pageName != 'link.php')) {
+		if ($('#navigation').length) {
+			var hasNavigation = true;
+		} else {
+			var hasNavigation = false;
+		}
+
+		if (hasNavigation && ($(this).hasClass('selected') || (pageName == page && pageName != 'graph_view.php') && pageName != 'link.php')) {
 			handleUserMenu(true);
 		} else {
 			var id   = $(this).attr('id');