Fixing #5197 - Remote Agent Graphs

Realtime graph on remote poller not working in 1.2.23
Cacti · Jan 27, 2023 · b126de7 · b126de7
1 parent 22d96d0
commit b126de7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -33,6 +33,7 @@ Cacti CHANGELOG
 -issue#5190: When using Gradient Support GPRINT Text Format is misaligned
 -issue#5195: Spikekill Backtrace Argument #1 ($string) must be passed by reference, value given
 -issue#5196: Gradient support breaks certain Graphs with special characters in them
+-issue#5197: Realtime graph on remote poller not working in 1.2.23
 -issue#5198: PHP Diff Renderer throws warnings
 -issue#5199: Failures to call fgets generate errors in the Cacti.log
 

diff --git a/remote_agent.php b/remote_agent.php
@@ -298,9 +298,14 @@ function poll_for_data() {
 
 	$local_data_ids = get_nfilter_request_var('local_data_ids');
 	$host_id        = get_filter_request_var('host_id');
-	$poller_id      = get_filter_request_var('poller_id');
+	$poller_id      = get_nfilter_request_var('poller_id');
 	$return         = array();
 
+	/* ensure we have a valid poller_id */
+	if (!preg_match('/[^A-Z\0-9]/i', $poller_id)) {
+		return array();
+	}
+
 	$i = 0;
 
 	if (cacti_sizeof($local_data_ids)) {