Skip to content

Commit

Permalink
Use the correct logging level for issue #1245
Browse files Browse the repository at this point in the history
  • Loading branch information
@cigamit
cigamit committed Feb 5, 2018
1 parent 410b752 commit bdb2bf6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions data_queries.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -422,11 +422,11 @@ function data_query_sv_check_sequences($type, $snmp_query_graph_id, $field_name)

// report any bad or duplicate sequencs to the log for reporting purposes
if ($bad_seq > 0) {
cacti_log('WARN: Found ' . $bad_seq . " Bad Sequences in $talbe Table", false, 'WEBUI', POLLER_VERBOSITY_LOW);
cacti_log('WARN: Found ' . $bad_seq . " Bad Sequences in $talbe Table", false, 'WEBUI', POLLER_VERBOSITY_HIGH);

This comment has been minimized.

Sign in to view

Copy link
@reboot1983

reboot1983 Feb 5, 2018

Contributor

This is a typo, I assume? $talbe ?

This comment has been minimized.

Sign in to view

Copy link
@netniV

netniV Feb 5, 2018

Member

I would say so. Good catch.

This comment has been minimized.

Sign in to view

Copy link
@cigamit

cigamit Feb 5, 2018

Author Member

Bah humbug ;) Fixed now.

This comment has been minimized.

Sign in to view

Copy link
@cigamit

cigamit Feb 5, 2018

Author Member

I can not imagine that one every triggering anyway, sequence is an unsigned integer. But @netniV wrote such good code, I just did a cut and paste for the most part.

This comment has been minimized.

Sign in to view

Copy link
@netniV

netniV Feb 6, 2018

Member

Yeah, I didn't get that condition to trigger myself so missed the typo. That's where I miss the stricter c# compiler which picks up on things like that especially since they introduced the $"My variable is {variable}" formatting style which makes things really nice and clear but yet still errors with an unknown variable.
}

if ($dup_seq > 0) {
cacti_log('WARN: Found ' . $dup_seq . " Duplicated Sequences in $table Table", false, 'WEBUI', POLLER_VERBOSITY_LOW);
cacti_log('WARN: Found ' . $dup_seq . " Duplicated Sequences in $table Table", false, 'WEBUI', POLLER_VERBOSITY_HIGH);
}

if ($bad_seq > 0 || $dup_seq > 0) {
Expand Down

0 comments on commit bdb2bf6

Please sign in to comment.