Resolving issue #2456

When attempting to display actions that can be taken, having no actions caused error
Cacti · Feb 26, 2019 · ff0bb7b · ff0bb7b
1 parent 6c02860
commit ff0bb7b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -3,6 +3,7 @@ Cacti CHANGELOG
 1.2.3
 -issue#2452: Missing 'getSNMPQueries()' function when calling add_data_query.php
 -issue#2453: Cannot retrieve list of snmp values via CLI
+-issue#2456: When attempting to display actions that can be taken, having no actions caused error
 
 1.2.2
 -issue#599: Aggregate graph templates assume AVG consolidation function

diff --git a/lib/html.php b/lib/html.php
@@ -1372,6 +1372,10 @@ function draw_menu($user_menu = "") {
 function draw_actions_dropdown($actions_array, $delete_action = 1) {
 	global $config;
 
+	if ($actions_array === NULL || cacti_sizeof($actions_array) == 0) {
+		return;
+	}
+
 	if (!isset($actions_array[0])) {
 		$my_actions[0]  = __('Choose an action');
 		$my_actions    += $actions_array;