Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version compare function fails on major/minor only versions (Host MIB plugin says it's needs > 1.1.4 when on 1.1.28) #1164

Closed
netniV opened this issue Jan 2, 2018 · 6 comments

Comments

@netniV
Copy link
Member

netniV commented Jan 2, 2018

image

As you can see from the screenshot, for some reason a plugin that I disabled as I don't really use it is now unavailable to re-enable as it believes I need a version of cacti which is greater than 1.1.4

Not entirely sure if that message comes from the plugin or cacti but it seems to be in error since I'm running 1.1.29

@cigamit
Copy link
Member

cigamit commented Jan 2, 2018

Please update lib/functions.php from Develop. That will resolve this issue. We will be releasing 1.1.30 sometime later this week.

@cigamit
Copy link
Member

cigamit commented Jan 6, 2018

This is resolved in 1.1.30

@cigamit cigamit closed this as completed Jan 6, 2018
@cigamit
Copy link
Member

cigamit commented Jan 6, 2018

Damn. Just noticed that this is still an issue.

@cigamit cigamit reopened this Jan 6, 2018
cigamit added a commit that referenced this issue Jan 6, 2018
Additional issues with cacti_version_compare function
@cigamit
Copy link
Member

cigamit commented Jan 6, 2018

Resolved now. Pretty embarrassed about this one.

@cigamit cigamit closed this as completed Jan 6, 2018
@netniV
Copy link
Member Author

netniV commented Jan 6, 2018

I was slightly confused into thinking we were still releasing 1.1.30 reading this. Should it be added to the CHANGELOG ? Obviously without the embarrassment ;-)

@cigamit
Copy link
Member

cigamit commented Jan 6, 2018

Yea well sort of. It was broken -> sort of fixed -> now fixed. This latest patch would only affect someone whose version was represented in two digits (aka 1.2 instead of 1.2.0). So, it would only impact people doing dev on 1.2(.0). So, the real fix will be to change the 1.2 version to 1.2.0. However, if this happens again in the future (1.3 for example), we won't have fix another bug. Was that what you experienced too?

@ronytomen ronytomen changed the title Host MIB plugin says it's needs > 1.1.4 when on 1.1.28 Version compare function fails on major/minor only versions (Host MIB plugin says it's needs > 1.1.4 when on 1.1.28) Jan 15, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants