Send A Test Email stops working under PHP 7.3

[justmace]

Describe the bug
I'm using cacti 1.2.2.
With PHP 7.1 and 7.2, the test email works perfectly, but as soon as I upgraded it to PHP 7.3 it stopped working ( log section above )
Tried clean installs with PHP 7.1, 7.2 and 7.3, it only failed with PHP 7.3.
( btw, tried all mail services, the results are the same)

To Reproduce
Steps to reproduce the behavior ( with PHP 7.3 ):

1. Go to 'Settings->Mail/Reporting/DNS'
2. Complete the fields
3. Click 'Send a Test Email'
4. See error

Expected behavior

(Cacti log)
2019/03/14 16:58:00 - MAILER WARNING: Mail failed via PHP Mail() Function from 'Cacti something@gmail.com', to '', cc '', Subject 'Cacti Test Message', Error: You must provide at least one recipient email address.
2019/03/14 16:58:00 - CMDPHP PHP ERROR WARNING Backtrace: (/settings.php[254]:email_test(), /lib/functions.php[3837]:send_mail(), /lib/functions.php[3263]:mailer(), /lib/functions.php[3418]:parse_email_details(), /lib/functions.php[3637]:split_emaildetail(), /lib/functions.php[3683]:preg_match(), CactiErrorHandler())
2019/03/14 16:58:00 - ERROR PHP WARNING: preg_match(): Compilation failed: invalid range in character class at offset 29 in file: /usr/share/cacti/lib/functions.php on line: 3683
2019/03/14 16:58:00 - CMDPHP PHP ERROR WARNING Backtrace: (/settings.php[254]:email_test(), /lib/functions.php[3837]:send_mail(), /lib/functions.php[3263]:mailer(), /lib/functions.php[3386]:parse_email_details(), /lib/functions.php[3637]:split_emaildetail(), /lib/functions.php[3683]:preg_match(), CactiErrorHandler())
2019/03/14 16:58:00 - ERROR PHP WARNING: preg_match(): Compilation failed: invalid range in character class at offset 29 in file: /usr/share/cacti/lib/functions.php on line: 3683
2019/03/14 16:58:00 - CMDPHP PHP ERROR WARNING Backtrace: (/settings.php[254]:email_test(), /lib/functions.php[3837]:send_mail(), /lib/functions.php[3263]:mailer(), /lib/functions.php[3386]:parse_email_details(), /lib/functions.php[3637]:split_emaildetail(), /lib/functions.php[3683]:preg_match(), CactiErrorHandler())
2019/03/14 16:58:00 - ERROR PHP WARNING: preg_match(): Compilation failed: invalid range in character class at offset 29 in file: /usr/share/cacti/lib/functions.php on line: 3683

Desktop (please complete the following information):

• OS: RHEL 7.4/ CentOS 7.4
• Browser: Chrome / Firefox
• Version: 73 / 65

Additional context
The problem might start somewhere in the function 'parse_email_details', I'll investigate a bit more as well.

[cigamit]

I'm voting for a PHP preg bug, but who knows.

[justmace]

I tested the preg_match here and also found this bug report on PHP website.

[OberonX]

hello, I am using version 1.2.2 from Debian and I have the same problem. I have gone up to 1.2.3 from GIT and I get the same error line: functions.php [3637]: split_emaildetail (), / lib / functions .php [3683]: preg_match (), CactiErrorHandler ()) etc,

[cigamit]

This is a bug in PHP 7.3 and not in Cacti. I would suggest that you open a Debian bug.

[OberonX]

Hello thank you, I have disabled 7.3 to use 7.0 in Apache, Regards! ...

[cigamit]

I'm going to keep this open for others. No need to close for now.

[netniV]

I will be testing this soon as I'm going to run a 1.3 development server on 7.3 to see what issues I get.

[OberonX]

hi !

I fixed this issue replacing regexp

$sPattern = '/([\w\s'"+]+[\s]+)?(<)?(([\w-.+]+)@((?:[\w-]+.)+)([a-zA-Z]{2,4}))?(>)?/';

with

$sPattern = '/([\w\s\'\"\+]+[\s]+)?(<)?(([\w\-.\+]+)@((?:[\w\-]+\.)+)([a-zA-Z]{2,4}))?(>)?/';

it works on Debian/Sid php7.3

::: Before replace REGEXP:

2019/04/16 15:02:41 - CMDPHP PHP ERROR WARNING Backtrace: (/settings.php[254]:email_test(), /lib/functions.php[3837]:send_mail(), /lib/functions.php[3263]:mailer(), /lib/functions.php[3418]:parse_email_details(), /lib/functions.php[3637]:split_emaildetail(), /lib/functions.php[3683]:preg_match(), CactiErrorHandler())

::after

2019/04/16 15:08:39 - MAILER INFO: Mail successfully sent via Función Mail() de PHP from 'emx --- oberon@unixmexico.org', to 'oberon@unixmexico.org', cc '', Subject 'Mensaje de prueba de Cact

[TheWitness]

Okay, your corrected syntax is right.

[justmace]

Works on my side, thanks ! If you want me to close this one, let me know.