Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When installing, chosen language is sometimes lost #2590

Closed
whsir opened this issue Apr 1, 2019 · 13 comments
Closed

When installing, chosen language is sometimes lost #2590

whsir opened this issue Apr 1, 2019 · 13 comments
Assignees
@netniV
Labels
bug Undesired behaviour
Milestone
v1.2.4

Comments

@whsir
Copy link

whsir commented Apr 1, 2019

Install 1.2.3 version
language change no succeed
no change
@netniV
Copy link
Member

netniV commented Apr 1, 2019 •
edited

I have just tested this without issue, please let us know if you have any browser console errors within the browser's developer tools

@whsir
Copy link
Author

whsir commented Apr 2, 2019

browser version Google Chrome 73.0.3683.86

@whsir
Copy link
Author

whsir commented Apr 2, 2019

f1

@whsir
Copy link
Author

whsir commented Apr 2, 2019

image
language no change

@whsir
Copy link
Author

whsir commented Apr 2, 2019

image
image

@netniV
Copy link
Member

netniV commented Apr 2, 2019

OK, so the issue is not that the language isn't changing, but that it keeps defaulting back to english?

@whsir
Copy link
Author

whsir commented Apr 2, 2019

yes，language defaulting english

@whsir
Copy link
Author

whsir commented Apr 2, 2019

Change again language
image

next、next、next...

Until he finished

image
image

language defaulting english

@whsir
Copy link
Author

whsir commented Apr 2, 2019

image

Change language，
must
Clear browser cache

@whsir
Copy link
Author

whsir commented Apr 2, 2019

now
if Settings language english
then
save no change
Clear browser cache，no change

now Chinese

Language switching should be a problem！

@whsir
Copy link
Author

whsir commented Apr 2, 2019

说了这么多，不知道你是否明白我的想法:smile:

@netniV
Copy link
Member

netniV commented Apr 2, 2019

OK, we will look into this

@netniV netniV self-assigned this Apr 2, 2019
@netniV netniV added the bug Undesired behaviour label Apr 2, 2019
@netniV netniV added this to the v1.2.4 milestone Apr 2, 2019
@netniV netniV mentioned this issue Apr 2, 2019
Closed
@TheWitness
Copy link
Member

What do you guys thing about storing the last language used in localStorage, that way the login/logout will work as well (at least on the browser you last logged into).

@netniV netniV changed the title 1.2.3version language change failed Language selection allows to 'lose' correct setting Apr 3, 2019
@netniV netniV changed the title Language selection allows to 'lose' correct setting Language selection is not working as expected Apr 4, 2019
@netniV netniV closed this as completed in 013c8eb Apr 4, 2019
netniV added a commit that referenced this issue Apr 5, 2019
@netniV
Resolves multiple issues:
6456db3 
-issue#2590: Language selection is not working as expected
-issue#2605: When checking for tables to upgrade, undefined variable $config error occurs
-issue#2608: db_update_table() function should not require an engine type or comment
-issue#2610: Data Sources troubleshooter generates warning that each() function is deprecated

Closes #2590, 2605, 2608, 2610
@netniV netniV changed the title Language selection is not working as expected When installing, chosen language is sometimes lost Apr 28, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@netniV netniV

Labels
bug Undesired behaviour
Projects
None yet
Milestone
v1.2.4
Development

No branches or pull requests
3 participants
@TheWitness @netniV @whsir