Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphs can not properly handle negative axis values #3457

Closed
F-i-f opened this issue Apr 12, 2020 · 2 comments
Closed

Graphs can not properly handle negative axis values #3457

F-i-f opened this issue Apr 12, 2020 · 2 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
1.2.12

Comments

@F-i-f
Copy link
Contributor

F-i-f commented Apr 12, 2020

Describe the bug

In the Cacti 1.211 Graph and Graph Templates pages, the right axis scale is not allowed to be negative. However rrdtool handles negative scales (in effect flipping the right axis).

To Reproduce

Steps to reproduce the behavior:

  1. Log in into Cacti.
  2. Navigate to the Console
  3. In the left menu bar, scroll down to Management > Graphs
  4. Edit any existing graph or create a new one.
  5. Scroll down to Axis Options.
  6. In the Right Axis text field, enter -1:0.
  7. Click Save.

Expected behavior

The graph should be saved, but instead Cacti refuses to save the graph and issues the error: Save Failed due to field input errors (Check red fields)..

Desktop (please complete the following information)

  • OS: Linux
  • Browser: Firefox

Additional context

The same issue exists for Graph Template.
@F-i-f F-i-f added bug Undesired behaviour unverified Some days we don't have a clue labels Apr 12, 2020
@F-i-f F-i-f mentioned this issue Apr 12, 2020
Closed
@TheWitness TheWitness removed the unverified Some days we don't have a clue label Apr 15, 2020
@TheWitness TheWitness added this to the 1.2.12 milestone Apr 15, 2020
TheWitness pushed a commit that referenced this issue Apr 16, 2020
@F-i-f
Fixing Issue #3457 (#3465)
75e2e3b 
Allow graph right_axis scale to be negative.
Negative scales are supported by rrdtool.
Also improve the regular expression used for matching numbers.
@TheWitness
Copy link
Member

@F-i-f, that's for your contribution. I'm going to mark this one resolved. You can close once you have verified that everything is as you would expect it to be.

@TheWitness TheWitness added the resolved A fixed issue label Apr 16, 2020
@F-i-f
Copy link
Contributor Author

F-i-f commented Apr 17, 2020

All looks good. Thank for your responsiveness and work on Cacti.

@F-i-f F-i-f closed this as completed Apr 17, 2020
@netniV netniV added the confirmed Bug is confirm by dev team label Apr 26, 2020
@netniV netniV changed the title Graph right axis scale can be negative. Cacti does not allow graphs to handle negative axis properly May 3, 2020
@netniV netniV changed the title Cacti does not allow graphs to handle negative axis properly Graphs can not properly handle negative axis values May 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
1.2.12
Development

No branches or pull requests
3 participants
@TheWitness @netniV @F-i-f