When installing templates, default 'all' selection will reset all existing graphs, removing customisations

[eschoeller]

There is a new menu in the installer allowing you to select which templates to use. From other discussions I've seen, I understand where you are headed here. But honestly this freaked me out! In my situation I have been using some of these templates for, like a decade. I know I have likely changed one or two things here or there, at some point in my history. SO, there's no way I want to overwrite these! But what if I don't select them? Would they be removed? Probably not - just like every other upgrade I've ever done. All my templates will just transfer over as they always do. But what if they don't?? Or, will the installer be smart enough to see I've made changes and not blow them away or import them at all?

...... SO many questions. I unchecked them all. So far, I feel good about my decision:) I wonder whether this menu should even be included in the upgrade process at all? Seems like a new install only type thing.
Thanks!

[TheWitness]

And, it's gone.

[TheWitness]

Two serious mistake were made:

1. Checking all the templates by default during upgrade
2. Turning on orphan cleaning automatically.

The first issue is there, the second issue was resolved yesterday. It wasn't that Cacti was hanging, but rather it was reverting all your changed graphs to their updated (or un-customized) template.

So, yea, big mistake. Moving forward, we will implement a versioning system so that once you have the template you like, you can essentially rehash it, so that it becomes immune to the mistake that was make with 1.2.11.

[TheWitness]

I've added a warning and defaulted them to 'unchecked' for upgrades. For new install, the behavior will remain the same.

[eschoeller]

Why not just remove it entirely for an upgrade?

[TheWitness]

I had actually thought about that at length yesterday. It really caused a lot of damage to peoples systems. Until we get make a few design changes, maybe we should.

@netniV, what do you think?

[netniV]

I'm sure at one point it wasn't available for upgrades, then we added because of people coming from pre-1.x systems.

[gdsotirov]

I made the mistake of leaving the checks (see https://forums.cacti.net/viewtopic.php?f=21&t=60841), so I'll be more careful on next upgrade, but hopefully it won't be necessary as the problem is being considered and addressed.