Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template to Device sync provides no feedback #3597

Closed
netniV opened this issue Jun 7, 2020 · 3 comments
Closed

Template to Device sync provides no feedback #3597

netniV opened this issue Jun 7, 2020 · 3 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@netniV
Copy link
Member

netniV commented Jun 7, 2020

Describe the bug

When syncing templates back to devices, no feedback is shown on screen once the "Continue" button is pressed. This means, you have no idea whether there is anything occurring and/or it is errored/locked up.

To Reproduce

Steps to reproduce the behavior:

  1. Modify a template with a large number of items based upon it.

  2. Sync changes and after clicking continue, see nothing back.

Expected behavior

Long running processes such as this should use a background process to execute with a status display returned that the front end can display whilst it is in progress.

Ideally, long term, all actions should operate this way to provide consistency.

Screenshots

image

Additional context

Any request made to the web should take no more than 5-10 seconds to complete. This prevents issues were users believe that they have either broken something or it's not running at all.

@netniV netniV added bug Undesired behaviour unverified Some days we don't have a clue labels Jun 7, 2020
@TheWitness
Copy link
Member

Yea, this whole thing should be backgrounded if it's going to take that long. I really don't know why it takes so long actually. I'll do a quick check. I suspect is re-running all queries, which should not be happening.

TheWitness added a commit that referenced this issue Jun 13, 2020
Template to Device sync provides no feedback
@TheWitness
Copy link
Member

TheWitness commented Jun 13, 2020

Okay, I've made an update that should make things very fast now, especially if there are no changes. As a feature request, we should allow this process to be backgrounded if you have thousands of devices and your are adding a few large data queries.

@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Jun 13, 2020
@TheWitness TheWitness added this to the 1.2.13 milestone Jun 13, 2020
@netniV
Copy link
Member Author

netniV commented Jun 13, 2020

We shouldn’t close this as it was for the original background enhancement that is still outstanding.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants