Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When adding datasource fails from CLI, created Datasource ID should be printed #3647

Closed
rlaager opened this issue Jun 29, 2020 · 1 comment
Closed

When adding datasource fails from CLI, created Datasource ID should be printed #3647

rlaager opened this issue Jun 29, 2020 · 1 comment
Labels
enhancement General tag for an enhancement resolved A fixed issue
Milestone
1.2.13

Comments

@rlaager
Copy link
Contributor

rlaager commented Jun 29, 2020

Feature Request

In a local script, we are calling e.g. /usr/share/cacti/cli/add_datasource.php --host-id=261 --data-template-id=90. It does not print out the ID of the DS created. We need the ID for further steps.

Describe the solution you'd like

I would like it to print $local_data_id in some form.

Describe alternatives you've considered

We have considered doing all the work of add_datasource.php in our script. That would be a lot of duplicated effort.
@rlaager rlaager added the enhancement General tag for an enhancement label Jun 29, 2020
rlaager added a commit to rlaager/cacti that referenced this issue Jun 29, 2020
@rlaager
Print the DS ID
06e206e 
Closes: Cacti#3647
Signed-off-by: Richard Laager <rlaager@wiktel.com>
rlaager added a commit to rlaager/cacti that referenced this issue Jun 29, 2020
@rlaager
Print the DS ID
482d31e 
Closes: Cacti#3647
Signed-off-by: Richard Laager <rlaager@wiktel.com>
@rlaager rlaager mentioned this issue Jun 30, 2020
Merged
TheWitness added a commit that referenced this issue Jun 30, 2020
@rlaager @TheWitness
Print the DS ID (#3650)
3376792 
Closes: #3647
Signed-off-by: Richard Laager <rlaager@wiktel.com>

Co-authored-by: TheWitness <thewitness@cacti.net>
@TheWitness TheWitness added the resolved A fixed issue label Jul 2, 2020
@TheWitness TheWitness added this to the 1.2.13 milestone Jul 2, 2020
@TheWitness
Copy link
Member

Thanks!

@netniV netniV changed the title add_datasource.php should print the created ID add_datasource.php should print the created Datasource ID Jul 12, 2020
@netniV netniV changed the title add_datasource.php should print the created Datasource ID When Adding datasource fails from CLI, created Datasource ID should be printed Jul 12, 2020
@netniV netniV changed the title When Adding datasource fails from CLI, created Datasource ID should be printed When adding datasource fails from CLI, created Datasource ID should be printed Jul 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Milestone
1.2.13
Development

No branches or pull requests
2 participants
@rlaager @TheWitness