Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbers are not always formatted properly when there are no decimal places #3835

Closed
TheWitness opened this issue Sep 29, 2020 · 0 comments
Closed

Numbers are not always formatted properly when there are no decimal places #3835

TheWitness opened this issue Sep 29, 2020 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.15

Comments

@TheWitness
Copy link
Member

Describe the bug

When using number format the localization functions can return an empty decimal and thousands separator, which leads to broken rendering.

Expected behavior

Cacti should use reasonable defaults (US), when they are empty.
@TheWitness TheWitness added the bug Undesired behaviour label Sep 29, 2020
@TheWitness TheWitness added this to the 1.2.15 milestone Sep 29, 2020
TheWitness added a commit that referenced this issue Sep 29, 2020
@TheWitness
Fixing Issue #3835
93d02b9 
The function number_format_18n() does not properly use the decimal and thousands separators in some cases
@TheWitness TheWitness added the resolved A fixed issue label Sep 29, 2020
@netniV netniV changed the title The function number_format_18n() does not properly use the decimal and thousands separators in some cases Numbers are not always formatted properly when there are no decimal places Nov 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.15
Development

No branches or pull requests
1 participant
@TheWitness