Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete items from a previous polling session may be updated twice #4266

Closed
ddb4github opened this issue May 17, 2021 · 4 comments
Closed

Incomplete items from a previous polling session may be updated twice #4266

ddb4github opened this issue May 17, 2021 · 4 comments
Assignees
@netniV
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
1.2.18

Comments

@ddb4github
Copy link
Contributor

Describe the bug

Duplicate code block in poller.php since fixing of #1511

To Reproduce

Review poller.php line 247-265 and line 267-285

Reference

Code commit 88974b9 and 63585dd
@ddb4github ddb4github added bug Undesired behaviour unverified Some days we don't have a clue labels May 17, 2021
@netniV netniV added confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels May 17, 2021
@netniV netniV self-assigned this May 17, 2021
@netniV netniV added this to the 1.2.18 milestone May 17, 2021
@netniV netniV changed the title Duplicate code block in poller.php When there are output items remaining from previous run, poller may try to update these twice May 17, 2021
@netniV netniV changed the title When there are output items remaining from previous run, poller may try to update these twice Incomplete pPoller items from a previous run may be updated twice May 17, 2021
@netniV netniV changed the title Incomplete pPoller items from a previous run may be updated twice Incomplete Poller items from a previous run may be updated twice May 17, 2021
netniV added a commit that referenced this issue May 17, 2021
@netniV
Incomplete Poller items from a previous run may be updated twice #4266
1a23052
@netniV
Copy link
Member

netniV commented May 17, 2021

Thanks, I would agree with this and have now removed the duplicate code block.

@netniV netniV closed this as completed May 17, 2021
@netniV netniV added the resolved A fixed issue label May 17, 2021
@TheWitness
Copy link
Member

@netniV there is likely a problem with this. When instances > 1, both data sources must be updated in the same poller interval. Do we have a use case where this breaks something?

@netniV
Copy link
Member

netniV commented May 19, 2021

The code for that is still present, it was duplicated.

@TheWitness
Copy link
Member

Okay, good enough.

@netniV netniV removed the confirmed Bug is confirm by dev team label Jun 9, 2021
@netniV netniV changed the title Incomplete Poller items from a previous run may be updated twice Incomplete items from a previous polling session may be updated twice Jul 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@netniV netniV

Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
1.2.18
Development

No branches or pull requests
3 participants
@TheWitness @netniV @ddb4github