Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Import graph template(Preview Only) show color_id new value as empty #4289

Closed
ddb4github opened this issue Jun 3, 2021 · 4 comments
Closed

Minor: Import graph template(Preview Only) show color_id new value as empty #4289

ddb4github opened this issue Jun 3, 2021 · 4 comments
Labels
bug Undesired behaviour

Comments

@ddb4github
Copy link
Contributor

Describe the bug

Import graph template(Preview Only) show color_id new value as empty

    Table: graph_templates_item, Column: color_id, New Value: , Old Value: 455

To Reproduce

  1. Go to 'Console-->Export Templates'
  2. Export anyone graph template
  3. Edit exported xml, and modify anyone graph item color as a nonexistent color in cacti db. e.g. 4466EE
  4. Import modified xml file with "Preview Import Only(checked, default)"
  5. Review output in page

Expected behavior

Show 'color hex' or some message like '[new color]
@ddb4github ddb4github added bug Undesired behaviour unverified Some days we don't have a clue labels Jun 3, 2021
@TheWitness
Copy link
Member

Has there been a pull request on this @ddb4github?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the outdated No recent activity label Aug 25, 2021
@github-actions github-actions bot closed this as completed Sep 1, 2021
@TheWitness
Copy link
Member

Any Pull Request? @ddb4github

@TheWitness TheWitness reopened this Sep 25, 2021
@TheWitness TheWitness removed unverified Some days we don't have a clue outdated No recent activity labels Sep 25, 2021
@TheWitness
Copy link
Member

No feedback.

@ddb4github ddb4github mentioned this issue Oct 8, 2021
Merged
ddb4github pushed a commit to ddb4github/cacti that referenced this issue Oct 8, 2021
Fixed: Update CHANGELOG for Cacti#4289
878f00a
TheWitness added a commit that referenced this issue Oct 8, 2021
@ddb4github @TheWitness
Fix#4289: Display color style instead of color_id or blank for new co…
0519802 
…loer. (#4416)

* Fix#4289: Display color style instead of color_id or blank for new coloer.
          Remove html_escape for import->result->differences display to avoid double escape

* Fixed: Update CHANGELOG for #4289

* Fomatting

* Formatting

Co-authored-by: Jing Chen <jingchen@cn.ibm.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheWitness @ddb4github