Unable to search using regular expressions when trying to filter graphs

[michaelwingender]

If you want to use a RegEx when filtering for Graphs in TreeView or Preview View, filters are not applied correctly. I don't see any results. I have graphs with with title "devicename has a bgp session" and many others. Up to 1.2.16 it was possible to see all the graphs with the filter "device.*bgp.*". Since 1.2.17 this is not possible any more.

I have found out that the changes that were applied in #4080 introduced the problem. After reverting the appropriate lines I can use RegEx as filter again. So the fix introduced another problem on my site.

[TheWitness]

Okay, verified. RegEx's are for tech's not DBA's ;)

[TheWitness]

Should be working now.

[michaelwingender]

Confirmed for "Preview View". It is working here. In "Tree View" it is not. Here preg_quote also needs to be removed to be able to use regex.

[TheWitness]

Okay, Tree view fixed as well now. Thanks!

[bernisys]

Proposal:

I remember the preg_quote was added at some place in the code to fix a different other issue with using special chars (was it slashes or hashes or so?) in a search ... i found that pretty clumsy, as pointed out here, it destroys the use of regexes.

While I am definitely pro-regex (plus many colleagues as well), i still think this should be properly annotated in a pop-up, something like:

"If you want to search for special characters: (.... list ... ) you need to escape them by prefixing with a backslash ""

Anyways, thanks for bringing back the essential functionality ;)

[Kveri]

Hi, is this really fixed everywhere? I have 1.2.18 and I was unable to use regexp in graph search filter. I had to remove preg_quote from all lines in lib/html_tree.php