Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce repeatative warnings when resources are exhausted #4315

Closed
TheWitness opened this issue Jun 20, 2021 · 0 comments
Closed

Reduce repeatative warnings when resources are exhausted #4315

TheWitness opened this issue Jun 20, 2021 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
1.2.18

Comments

@TheWitness
Copy link
Member

Describe the bug

If for some strange reason, Cacti runs out of file descriptors and can not fork RRDtool, don't generate TB of logs attempting to read from the end of a null pointer.

To Reproduce

It's hard, but trust me, big logs.

Expected behavior

Don't generate logs in these select cases.
@TheWitness TheWitness added the bug Undesired behaviour label Jun 20, 2021
@TheWitness TheWitness added this to the 1.2.18 milestone Jun 20, 2021
TheWitness added a commit that referenced this issue Jun 20, 2021
@TheWitness
Fixing two performance bugs #4314 and #4315
38399be 
- If Cacti runs out of resources (file descriptions via a ulimit) and DSStats is running, don't flood the Cacti log with errors
- When disabling the snmpagent, you can introduce significant delay to data collection
@TheWitness TheWitness added the resolved A fixed issue label Jun 20, 2021
@netniV netniV closed this as completed Jun 30, 2021
@netniV netniV changed the title If Cacti runs out of resources (file descriptions via a ulimit) and DSStats is running, don't flood the Cacti log with errors Reduce repeatative warnings when resources are exhausted Jul 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
1.2.18
Development

No branches or pull requests
2 participants
@TheWitness @netniV