Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP API lacks timeout options leading to bad login experiences #4445

Closed
TheWitness opened this issue Oct 26, 2021 · 3 comments
Closed

LDAP API lacks timeout options leading to bad login experiences #4445

TheWitness opened this issue Oct 26, 2021 · 3 comments
Labels
authentication Authentication related issue/feature bug Undesired behaviour ldap Issue related to ldap authentication resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug

The LDAP API in php provides two timeout options for both network (syn) and bind. The default is approximately two minutes. These defaults are too high and should be reduced or rather be configurable.

To Reproduce

Steps to reproduce the behavior:

  1. Set your primary server to a host that is printable, but down

  2. Logout of Cacti

  3. Attempt to login

  4. See error

Expected behavior

Cacti should fail over to the second server if the syn does not come back in two seconds. This should be approximately the same for the connect.

@TheWitness TheWitness added bug Undesired behaviour unverified Some days we don't have a clue ldap Issue related to ldap authentication authentication Authentication related issue/feature and removed unverified Some days we don't have a clue labels Oct 26, 2021
@TheWitness TheWitness added this to the v1.2.19 milestone Oct 26, 2021
@netniV
Copy link
Member

netniV commented Oct 26, 2021

Just remember that timeouts for searching a directory may need to be longer since traversing can be slower. That happens at bind or search stages because of the user information. 120 seconds though is too longer a default. If someone needs that, it should be configurable I agree.

@TheWitness
Copy link
Member Author

Hmm, the syn should be quick, the bind may take longer. Should we have two settings then?

@TheWitness
Copy link
Member Author

Going to make these global settings. We can incorporate the domains plugin in 1.3.

TheWitness added a commit that referenced this issue Oct 26, 2021
LDAP API lacks timeout options leading to bad login experiences.  Domains will use the global setting for now.
@TheWitness TheWitness added the resolved A fixed issue label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
authentication Authentication related issue/feature bug Undesired behaviour ldap Issue related to ldap authentication resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants