Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When attempting to calculate width, some input elements may cause console errors #4498

Closed
TheWitness opened this issue Dec 9, 2021 · 3 comments
Closed

When attempting to calculate width, some input elements may cause console errors #4498

TheWitness opened this issue Dec 9, 2021 · 3 comments
Assignees
@TheWitness
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.20

Comments

@TheWitness
Copy link
Member

Describe the bug

The Cacti jQuery function textBoxWidth() does not work work on tags resulting in the drop_callback class of form elements not sizing correctly.

Expected behavior

The jQuery function should work regardless of it being a input or a td, span, etc.
@TheWitness TheWitness added the bug Undesired behaviour label Dec 9, 2021
@TheWitness TheWitness added this to the v1.2.20 milestone Dec 9, 2021
@TheWitness TheWitness self-assigned this Dec 9, 2021
TheWitness added a commit that referenced this issue Dec 9, 2021
@TheWitness
Fixing Issue #4498 - drop_callback width issue
befc900 
Layout function textBoxWidth() does not work on input type form elements
@TheWitness
Copy link
Member Author

@netniV, can you review the commit?

@TheWitness TheWitness added the resolved A fixed issue label Dec 10, 2021
@netniV
Copy link
Member

netniV commented Jan 4, 2022

@TheWitness did you see the review?

@TheWitness
Copy link
Member Author

Yea, I was okay with the one regression. If you would like to enhance. Go for it.

@netniV netniV changed the title Layout function textBoxWidth() does not work on input type form elements When attempting to calculate width, some input elements may cause console errors Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheWitness TheWitness

Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.20
Development

No branches or pull requests
2 participants
@TheWitness @netniV