Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Items for a Graph Template may be slow on larger systems #4509

Closed
TheWitness opened this issue Dec 21, 2021 · 2 comments
Closed

Updating Items for a Graph Template may be slow on larger systems #4509

TheWitness opened this issue Dec 21, 2021 · 2 comments
Assignees
@TheWitness
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.20

Comments

@TheWitness
Copy link
Member

Describe the bug

When making small modifications to a Graph Template on very large systems with tens of thousands of graph, the process can take a long time to complete in the orders of tens of minutes, which causes web server and proxy timeouts.

To Reproduce

Steps to reproduce the behavior:

  1. Edit a Graph Template with 50k Graphs

  2. Edit any Graph Item

  3. Press Save

  4. Go get a coffee

  5. Beat the cat

  6. Read War and Peace

  7. Come back and find that the save never finished

Expected behavior

Cacti should save Templates in an efficient manner.
@TheWitness TheWitness added the bug Undesired behaviour label Dec 21, 2021
@TheWitness TheWitness added this to the v1.2.20 milestone Dec 21, 2021
TheWitness added a commit that referenced this issue Dec 21, 2021
@TheWitness
Fixing Issue #4509 - Slow Template Editing
af4911f 
* Graph Templating is quite slow on very large systems
* Update ChangLog for #4500 and #4495 as well
TheWitness added a commit that referenced this issue Dec 21, 2021
@TheWitness
QA on #4509 - Missed one variable removal
562a0e2
TheWitness added a commit that referenced this issue Dec 21, 2021
@TheWitness
Additional QA on #4509 - Graph Template Edit
902afe5
@TheWitness TheWitness self-assigned this Dec 21, 2021
TheWitness added a commit that referenced this issue Dec 21, 2021
@TheWitness
Additional boundary check on #4509
586628f 
This one ensures that you have a valid Graph Template  with Graph Template items before you attempt to instantiate graphs
@TheWitness
Copy link
Member Author

Still have one case that is not addressed, and there are still corner cases where performance is not good.

@TheWitness
Copy link
Member Author

I'm going to mark this resolved, though there is still room for improvement. It's must faster now anyway.

@TheWitness TheWitness added the resolved A fixed issue label Jan 29, 2022
@netniV netniV changed the title Updating Graph Template Items for a Template is Slow on Large Systems Updating Items for a Graph Template may be slow on larger systems Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheWitness TheWitness

Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.20
Development

No branches or pull requests
1 participant
@TheWitness