Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When entering custom input, layout issues may be seen #4522

Closed
TheWitness opened this issue Jan 3, 2022 · 0 comments
Closed

When entering custom input, layout issues may be seen #4522

TheWitness opened this issue Jan 3, 2022 · 0 comments
Assignees
@TheWitness
Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue
Milestone
v1.2.20

Comments

@TheWitness
Copy link
Member

Describe the bug

When you have a Graph Template that uses custom items from columns other than the 'task_item_id', the create graphs page will not show a header as with the image below.

image

This rendering is not accurate, and should be showing a header.

To Reproduce

Steps to reproduce the behavior:

  1. Create a Graph Template with an override for color_id

  2. Create a Graph with this Template

  3. Note, there is not table header as in the example above. Also the html does not pass w3 validation

Expected behavior

Cacti should render proper HTML with headers where they are expected to be.
@TheWitness TheWitness added bug Undesired behaviour gui UI related issue labels Jan 3, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Jan 3, 2022
@TheWitness TheWitness self-assigned this Jan 3, 2022
TheWitness added a commit that referenced this issue Jan 3, 2022
@TheWitness
Fixing Issue #4522 - New Graphs Header Issues
80948a9 
* When Creating New Graphs some visible 'Custom Input' values lack a table header
* Also did some cleanup on the custom input functions for consistency.
@TheWitness TheWitness added the resolved A fixed issue label Jan 3, 2022
@netniV netniV changed the title When Creating New Graphs some visible 'Custom Input' values lack a table header When entering custom input, layout issues may be seen Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheWitness TheWitness

Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue
Projects
None yet
Milestone
v1.2.20
Development

No branches or pull requests
1 participant
@TheWitness