Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a device, default setting for Device Threads may be ignored #4528

Closed
Vulcan1171 opened this issue Jan 14, 2022 · 2 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@Vulcan1171
Copy link

Describe the bug

When manually creating a new device in the 'Device [new]' form, the option 'Number of Collection Threads' will always start set to '1 Thread (default)' regardless of setting in 'Configuration->Settings->Device Defaults->Device Threads'.

Is this the expected behaviour?

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Configuration->Settings->Device Defaults'

  2. Modify value of 'Device Threads' from 1 to another value and save

  3. Go to 'Management->Devices->+ (new)' or 'Create->New Device'

  4. The option 'Number of Collection Threads' is still set to '1 Thread (default)'

Expected behavior

When the form for the creation of a new device is presented to the user, the option 'Number of Collection Threads' should be preset to the value selected in "Configuration->Settings->Device Defaults->Device Threads"

Additional context

Verified on Cacti version 1.2.19

2022-01-14_16h38_15
2022-01-14_16h38_25

@Vulcan1171 Vulcan1171 added bug Undesired behaviour unverified Some days we don't have a clue labels Jan 14, 2022
@TheWitness
Copy link
Member

Confirming.

@TheWitness TheWitness removed the unverified Some days we don't have a clue label Jan 17, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Jan 17, 2022
TheWitness added a commit that referenced this issue Jan 17, 2022
Default Setting "Device Threads" is ignored in device creation form
@TheWitness TheWitness added the resolved A fixed issue label Jan 17, 2022
@TheWitness
Copy link
Member

This is fixed no in the 1.2.x branch. Thanks for reporting!

@netniV netniV changed the title Default Setting "Device Threads" is ignored in device creation form when creating a device, default setting for Device Threads may be ignored Apr 3, 2022
@netniV netniV changed the title when creating a device, default setting for Device Threads may be ignored When creating a device, default setting for Device Threads may be ignored Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants