Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs not always display the correct path #4563

Closed
TheWitness opened this issue Feb 22, 2022 · 0 comments
Closed

Breadcrumbs not always display the correct path #4563

TheWitness opened this issue Feb 22, 2022 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug

Cacti breadcrumbs have always driven me mad. So, today I did a deep dive, and there is a bit of code that is not fully rationalized. The logic that was in place may have had a purpose at one time or another, but that purpose has long been diminished. So, a mild re-write was due. This bug is to record that re-write. In this change, we abandon the navigation cache, and simply construct the breadcrumb from the $navigation array that is passed for ever page including well written plugin pages.

Expected behavior

Cacti code should be easier to understand.

@TheWitness TheWitness added the bug Undesired behaviour label Feb 22, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Feb 22, 2022
TheWitness added a commit that referenced this issue Feb 22, 2022
 Cacti breadcrumbs are unreliable due to faulty navigation cache logic #4563
@TheWitness TheWitness added the resolved A fixed issue label Feb 22, 2022
@netniV netniV changed the title Cacti breadcrumbs are unreliable due to faulty navigation cache logic Breadcrumbs not always display the correct path Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant