Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file may be improperly moved into the resource cache #4607

Closed
TheWitness opened this issue Mar 11, 2022 · 2 comments
Closed

Configuration file may be improperly moved into the resource cache #4607

TheWitness opened this issue Mar 11, 2022 · 2 comments
Assignees
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug

This is partially a regression, but in discussions with @bmfmancini, we found that both the include/config.php and plugins/syslog/config.php are appearing in the resource cache. Upon an initial code inspection, the include/config.php should have been skipped and is not, but also, there is specific logic to INCLUDE any plugin config.php, which should not be correct, especially around syslog where we have a need to not replicate it.

Will have to perform a blame analysis to figure out why we specifically included plugin config.php, but the current thinking is that they should be excluded.

Expected behavior

Better Remote Data Collector Support

@TheWitness TheWitness added bug Undesired behaviour unverified Some days we don't have a clue and removed unverified Some days we don't have a clue labels Mar 11, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Mar 11, 2022
@TheWitness TheWitness self-assigned this Mar 11, 2022
@TheWitness TheWitness changed the title The config.php file is improperly moved into the resoruce cache as well as syslog's config.php The config.php file is improperly moved into the resource cache Mar 11, 2022
@TheWitness TheWitness changed the title The config.php file is improperly moved into the resource cache Cacti's config.php file is improperly moved into the resource cache Mar 11, 2022
TheWitness added a commit that referenced this issue Mar 11, 2022
Cacti's config.php file is improperly moved into the resource cache
@TheWitness TheWitness added the resolved A fixed issue label Mar 11, 2022
@TheWitness
Copy link
Member Author

Discussed this with @netniV and we agreed that by default Syslog's config.php should be replicated, and if a new Syslog feature were to be introduced for remote data collector processing, it should be done through config_local.php on the remote end.

@TheWitness
Copy link
Member Author

@bmfmancini, take note.

@netniV netniV changed the title Cacti's config.php file is improperly moved into the resource cache Configuration file may be improperly moved into the resource cache Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant